Store arrays offsets for scaled float fields natively with synthetic source #125793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-powers
added
>enhancement
auto-backport
|
Hi @jordan-powers, I've created a changelog YAML for you. |
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
jordan-powers
force-pushed
the
offset-encoding-scaled-float
branch
from
11f898f to
ba8e223
Compare
martijnvg
approved these changes
Mar 28, 2025
|
|
||
| @Override | ||
| protected void minimalMapping(XContentBuilder b) throws IOException { | ||
| b.field("type", "scaled_float").field("scaling_factor", 10.0); |
There was a problem hiding this comment.
Maybe turn the scaling factor into a constant here?
|
|
||
| @Override | ||
| protected String getFieldTypeName() { | ||
| return null; |
There was a problem hiding this comment.
why does this return null here?
There was a problem hiding this comment.
I see, because minimalMapping(...) gets overwritten here. So actually this method should never be invoked. Maybe add an assert false here? So it fails quick if this gets invoked?
|
|
||
| @Override | ||
| protected void minimalMapping(XContentBuilder b) throws IOException { | ||
| b.field("type", "scaled_float").field("scaling_factor", 10.0); |
There was a problem hiding this comment.
Maybe turn the scaling factor into a constant here?
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
…source (elastic#125793) This patch builds on the work in elastic#113757, elastic#122999, elastic#124594, elastic#125529, and elastic#125709 to natively store array offsets for scaled float fields instead of falling back to ignored source when synthetic_source_keep: arrays.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 28, 2025
…source (#125793) (#125891) This patch builds on the work in #113757, #122999, #124594, #125529, and #125709 to natively store array offsets for scaled float fields instead of falling back to ignored source when synthetic_source_keep: arrays. (cherry picked from commit 71e74bd) # Conflicts: # server/src/main/java/org/elasticsearch/index/IndexVersions.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch builds on the work in #113757, #122999, #124594, #125529, and #125709 to natively store array offsets for scaled float fields instead of falling back to ignored source when
synthetic_source_keep: arrays.